kurbezz/browser-wakatime
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Request host permissions for custom API servers on Firefox

Browse Source 
`content_scripts.matches` implies permissions to send cross-origin
requests on Chrome, but not on Firefox with Manifest V2. We need to
request permissions for custom API servers.
This commit is contained in:
Yufan You
2024-11-12 00:59:20 +08:00
parent 2aa07804c8
commit a934f2ced4
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/manifests/firefox.json
View File

@@ -38,6 +38,7 @@
"chrome_style": false, "chrome_style": false,
"page": "options.html" "page": "options.html"
}, },
"permissions": ["alarms", "tabs", "storage", "activeTab"], "permissions": ["alarms", "tabs", "storage", "activeTab", "https://api.wakatime.com/*", "https://wakatime.com/*"],
"optional_permissions": ["<all_urls>"],
"version": "4.0.9" "version": "4.0.9"
} }

7
src/utils/settings.ts
View File

@@ -81,5 +81,10 @@ export const getSettings = async (): Promise<Settings> => {
}; };
export const saveSettings = async (settings: Settings): Promise<void> => { export const saveSettings = async (settings: Settings): Promise<void> => {
return browser.storage.sync.set(settings); // permissions.request must be the first await, not after the browser.storage.sync.set
// See https://stackoverflow.com/a/47729896/12601364
await browser.permissions.request({
origins: [`${settings.apiUrl}/*`],
});
await browser.storage.sync.set(settings);
}; };